[Python-checkins] r42504 - python/trunk/Python/getargs.c

["Martin v. Löwis"]

Neal Norwitz wrote:
>>OTOH, this converts the number of actual arguments given. I believe
>>there is a limit on the number of arguments to a function call, of
>>2**31 (or is it 2**32?). So a Py_SAFE_DOWNCAST to int would also
>>work, IMO.
> 
> 
> I didn't read this close enough before checking in.  I missed the "to
> int" part.  Right now it downcasts to a long.  Do you think I should
> change it to downcast to an int instead of a long?

No: it should downcast to whatever it is going to print, then. As it
is printing %ld now, casting to long is right. I was just suggesting
that printing %d and casting to int would also have been right.

Regards,
Martin