[Python-checkins] commit of r41457 - python/trunk/Python

Neal Norwitz nnorwitz at gmail.com
Thu Nov 17 06:37:29 CET 2005


On 11/16/05, nick.coghlan at python.org <nick.coghlan at python.org> wrote:
> @@ -3191,8 +3199,6 @@
>         VISIT(c, expr, outermost_iter);
>         ADDOP(c, GET_ITER);
>         ADDOP_I(c, CALL_FUNCTION, 1);
> -       Py_DECREF(name);
> -       Py_DECREF(co);

I don't understand removing Py_DECREF(co);  It is added to
compiler_make_closure() and I think that there is a reference taken in
there.  This wasn't causing a problem.  In fact, I'm thinking that the
other places compiler_make_closure() is called are missing the
Py_DECREF(co).

Let me know what you think.  I'll try adding the DECREF's and see if
valgrind bitches.

n


More information about the Python-checkins mailing list