[Python-checkins] python/dist/src/Misc NEWS, 1.1193.2.44, 1.1193.2.45

mwh at users.sourceforge.net mwh at users.sourceforge.net
Thu Mar 31 12:20:42 CEST 2005


Update of /cvsroot/python/python/dist/src/Misc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3364/Misc

Modified Files:
      Tag: release24-maint
	NEWS 
Log Message:
Backport:

Fixes for

[ 1166660 ] The readline module can cause python to segfault

It seems to me that the code I'm rewriting here attempted to call any
user-supplied hook functions using the thread state of the thread that
called the hook-setting function, as opposed to that of the thread
that is currently executing.  This doesn't work, in general.

Fix this by using the PyGILState API (It wouldn't be that hard to
define a dummy version of said API when #ifndef WITH_THREAD, would
it?).

Also, check the conversion to integer of the return value of a hook
function for errors (this problem was mentioned in the ipython bug
report linked to in the above bug).



Index: NEWS
===================================================================
RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v
retrieving revision 1.1193.2.44
retrieving revision 1.1193.2.45
diff -u -d -r1.1193.2.44 -r1.1193.2.45
--- NEWS	31 Mar 2005 04:07:48 -0000	1.1193.2.44
+++ NEWS	31 Mar 2005 10:20:34 -0000	1.1193.2.45
@@ -10,6 +10,9 @@
 Extension Modules
 -----------------
 
+- Bug #1166660: The readline module could segfault if hook functions
+  were set in a different thread than that which called readline.
+
 - weakref proxy has incorrect __nonzero__ behavior.  SF bug #1770766.
 
 



More information about the Python-checkins mailing list