[Python-checkins] python/dist/src/Modules/expat macconfig.h, NONE, 1.1.2.1 asciitab.h, 1.1.1.1, 1.1.1.1.16.1 expat.h, 1.5, 1.5.12.1 iasciitab.h, 1.1.1.1, 1.1.1.1.16.1 internal.h, 1.1, 1.1.14.1 latin1tab.h, 1.1.1.1, 1.1.1.1.16.1 utf8tab.h, 1.1.1.1, 1.1.1.1.16.1 winconfig.h, 1.1.1.1, 1.1.1.1.16.1 xmlparse.c, 1.5, 1.5.12.1 xmlrole.c, 1.5, 1.5.12.1 xmltok.c, 1.3, 1.3.12.1 xmltok_impl.c, 1.2, 1.2.12.1 expat.h.in, 1.1.1.1, NONE

[Thomas Heller]

"Fred L. Drake, Jr." <fdrake at acm.org> writes:

> Thomas Heller writes:
>  > I'm getting compile errors on Windows (in the release-23maint branch,
>  > haven't tried in the trunk yet):
>
> I'll bet they match.  ;-)
>
>  > C:\sf\python\dist\src-maint23\Modules\expat\xmlparse.c(76) : fatal error
>  > C1189: #error : memmove does not exist on this platform, nor is a
>  > substitute available
>
> Hmm.  I see PC\pyconfig.h doesn't define HAVE_MEMMOVE; this gets
> defined in the configure-generated pyconfig.h for the Linux systems I
> tested this on.
>
> Doesn't Windows always have memmove()?  (I *think* it does based on a
> quick look at msdn.microsoft.com, but who knows for sure...)

Windows? MSVC has it.

> I'm not sure how extension building works on Windows; if setup.py is
> used, you should be able to define HAVE_MEMMOVE in PC\pyconfig.h,
> otherwise you can define it in the relevant .dsp file.

setup.py isn't used, and PC\pyconfig.h is manually maintained.
So HAVE_MEMMOVE has to be defined in this file, at least for MSVC6.
I don't know anything about watcom, borland, or other compilers.
Let's add it in the file and see what happens ;-)

Thomas