[Python-checkins] python/dist/src/Modules ossaudiodev.c,1.30,1.31

[Neil Schemenauer]

gward@users.sourceforge.net wrote:
> ***************
> *** 555,559 ****
>       case AFMT_U8:
>       case AFMT_S8:
> !         *ssize = sizeof(char);
>           break;
>       case AFMT_S16_LE:

sizeof(char) is, by definition, 1.

>       case AFMT_U16_BE:
> !         *ssize = sizeof(short);
>           break;
>       case AFMT_MPEG:
> --- 561,565 ----
>       case AFMT_U16_LE:
>       case AFMT_U16_BE:
> !         *ssize = 2;                     /* 16 bit formats: 1 byte */
>           break;
>       case AFMT_MPEG:

That comment is confusing.  Is the code expecting an integer with at
least 16 bits?  If that's true then the code is correct (since 1 byte
can hold at least 8 bits).  However, I would have expected the comment
to say "2 bytes".

  Neil