[Python-checkins] python/dist/src/Modules cPickle.c,2.111,2.112

tim_one@users.sourceforge.net tim_one@users.sourceforge.net
Sun, 02 Feb 2003 09:26:42 -0800


Update of /cvsroot/python/python/dist/src/Modules
In directory sc8-pr-cvs1:/tmp/cvs-serv22945/Modules

Modified Files:
	cPickle.c 
Log Message:
Beefed up the tests by putting in more "for proto in protocols:" outer
loops.  Renamed DATA and BINDATA to DATA0 and DATA1.  Included
disassemblies, but noted why we can't test them.  Added XXX comment to
cPickle about a mysterious comment, where pickle and cPickle diverge
in how they number PUT indices.


Index: cPickle.c
===================================================================
RCS file: /cvsroot/python/python/dist/src/Modules/cPickle.c,v
retrieving revision 2.111
retrieving revision 2.112
diff -C2 -d -r2.111 -r2.112
*** cPickle.c	2 Feb 2003 17:08:32 -0000	2.111
--- cPickle.c	2 Feb 2003 17:26:40 -0000	2.112
***************
*** 720,723 ****
--- 720,728 ----
  
  	/* Make sure memo keys are positive! */
+ 	/* XXX Why?
+ 	 * XXX And does "positive" really mean non-negative?
+ 	 * XXX pickle.py starts with PUT index 0, not 1.  This makes for
+ 	 * XXX gratuitous differences between the pickling modules.
+ 	 */
  	p++;