[Python-checkins] CVS: python/dist/src configure,1.288,1.289 configure.in,1.298,1.299 pyconfig.h.in,1.23,1.24

[Neal Norwitz]

"Martin v. L=F6wis" wrote:
>=20
> Neal Norwitz <neal@metaslash.com> writes:
>=20
> > Was this part intentional or was the patch I submitted broken?
>=20
> Neither, nor: pyconfig.h.in is a generated file, using autoheader. I
> just regenerated it. Any manual changes to it will be lost on
> regeneration.
>=20
> > I needed the #ifndef to stop a compiler warning about _FILE_OFFSET_BI=
TS
> > being redefined from /usr/include/sys/feature_tests.h on Solaris 8.
>=20
> Using the ifndef is incorrect. If Python sets _FILE_OFFSET_BITS, that
> should take precedence; feature_tests.h won't interfere. Can you point
> to the place where this caused problems?

I don't have the warning any more.  But I upgraded lots of stuff recently.
I agree that the #ifndef was bad, I was just trying to get rid of
a compiler warning, but since it's gone.  I'm happy.

Thanks,
Neal