[Python-checkins] CVS: python/dist/src/Lib robotparser.py,1.11,1.12

Martin v. L?wis loewis@users.sourceforge.net
Mon, 18 Mar 2002 02:41:23 -0800


Update of /cvsroot/python/python/dist/src/Lib
In directory usw-pr-cvs1:/tmp/cvs-serv4239

Modified Files:
	robotparser.py 
Log Message:
Patch #499513: use readline() instead of readlines(). Removed the 
unnecessary redirection limit code which is already in FancyURLopener.


Index: robotparser.py
===================================================================
RCS file: /cvsroot/python/python/dist/src/Lib/robotparser.py,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** robotparser.py	28 Feb 2002 15:24:47 -0000	1.11
--- robotparser.py	18 Mar 2002 10:41:20 -0000	1.12
***************
*** 5,9 ****
      You can choose between two licenses when using this package:
      1) GNU GPLv2
!     2) PYTHON 2.0 OPEN SOURCE LICENSE
  
      The robots.txt Exclusion Protocol is implemented as specified in
--- 5,9 ----
      You can choose between two licenses when using this package:
      1) GNU GPLv2
!     2) PSF license for Python 2.2
  
      The robots.txt Exclusion Protocol is implemented as specified in
***************
*** 43,47 ****
          opener = URLopener()
          f = opener.open(self.url)
!         lines = f.readlines()
          self.errcode = opener.errcode
          if self.errcode == 401 or self.errcode == 403:
--- 43,51 ----
          opener = URLopener()
          f = opener.open(self.url)
!         lines = []
!         line = f.readline()
!         while line:
!             lines.append(line.strip())
!             line = f.readline()
          self.errcode = opener.errcode
          if self.errcode == 401 or self.errcode == 403:
***************
*** 64,68 ****
  
          for line in lines:
-             line = line.strip()
              linenumber = linenumber + 1
              if not line:
--- 68,71 ----
***************
*** 210,215 ****
          apply(urllib.FancyURLopener.__init__, (self,) + args)
          self.errcode = 200
-         self.tries = 0
-         self.maxtries = 10
  
      def http_error_default(self, url, fp, errcode, errmsg, headers):
--- 213,216 ----
***************
*** 217,231 ****
          return urllib.FancyURLopener.http_error_default(self, url, fp, errcode,
                                                          errmsg, headers)
- 
-     def http_error_302(self, url, fp, errcode, errmsg, headers, data=None):
-         self.tries += 1
-         if self.tries >= self.maxtries:
-             return self.http_error_default(url, fp, 500,
-                                            "Internal Server Error: Redirect Recursion",
-                                            headers)
-         result = urllib.FancyURLopener.http_error_302(self, url, fp, errcode,
-                                                       errmsg, headers, data)
-         self.tries = 0
-         return result
  
  def _check(a,b):
--- 218,221 ----