[Python-checkins] python/dist/src/Modules unicodedata.c,2.16,2.17

[Fredrik Lundh]

andrew wrote:

> The routine at the centre of this was originally called _getname() before
> the _Py prefix was added.  There are also _gethash(), _cmpname() and
> _getcode() as well, all in a block prefaced with the comment
> 
>   /* database code (cut and pasted from the unidb package) */
> 
> There are other statics with a leading underscore in this file too.
> 
> I note your name at the top of the file :-)

fwiw, I wrote that code (and the unidb package it's taken from)

in my experience, simple names without underscores always conflicts
with something on platforms that I don't have access to, while simple
names with leading underscores never causes any problems...

> I don't have any particular favourite convention for this sort of thing,
> although I was trying to maintain the pre-existing convention.  However,
> going through the file I note that the prefix "unicodedata_" has been used
> for some of the other statics - this IMHO is probably slightly more
> fitting than "unicode_", no?

I vote for "unicodedata_".

</F>