[Python-checkins] python/dist/src/Lib formatter.py,1.20,1.21 ftplib.py,1.69,1.70 gettext.py,1.13,1.14 hmac.py,1.5,1.6

[Neil Schemenauer]

Andrew MacIntyre wrote:
> You have in fact changed the semantics of this test with your change.
> 
> In the case where file = '', the original would fall through to the
> elif, whereas with your change it won't.
> 
> It concerns me that your extensive changes have introduced some unexpected
> traps which won't be sprung until 2.3 is released.

I'm worried too.  What if someone passes their own class to one of these
functions and they implement keys() but not iterkeys() (or has_key() but
not __contains__)?

  Neil