[Python-checkins] CVS: python/nondist/sf-html sf-faq.html,1.12,1.13
Tim Peters
python-dev@python.org
Tue, 22 Aug 2000 20:58:48 -0700
Update of /cvsroot/python/python/nondist/sf-html
In directory slayer.i.sourceforge.net:/tmp/cvs-serv10958
Modified Files:
sf-faq.html
Log Message:
Update Patch Manager Guidlines, wrt de facto meanings of Open & Rejected.
Index: sf-faq.html
===================================================================
RCS file: /cvsroot/python/python/nondist/sf-html/sf-faq.html,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -r1.12 -r1.13
*** sf-faq.html 2000/08/10 03:51:09 1.12
--- sf-faq.html 2000/08/23 03:58:46 1.13
***************
*** 64,68 ****
<h2><a href="#appendix">A. Appendix</a></h2>
<ol>
! <li><a href="#a1">Patch Manager Guidelines [09.07.2000]</a></li>
<li><a href="#a2">Python Patch Submission Guidelines [29.06.2000]</a></li>
</ol>
--- 64,68 ----
<h2><a href="#appendix">A. Appendix</a></h2>
<ol>
! <li><a href="#a1">Patch Manager Guidelines [22.08.2000]</a></li>
<li><a href="#a2">Python Patch Submission Guidelines [29.06.2000]</a></li>
</ol>
***************
*** 547,551 ****
<blockquote>
The initial status of all patches.<br />
! The patch is under consideration, but has not been reviewed yet.<br />
The status will normally change to Accepted or Rejected next.<br />
The person submitting the patch should (if they can) assign it to the person
--- 547,552 ----
<blockquote>
The initial status of all patches.<br />
! The patch is under consideration, but has not been reviewed yet, or
! is under review but not yet Accepted or Rejected.<br />
The status will normally change to Accepted or Rejected next.<br />
The person submitting the patch should (if they can) assign it to the person
***************
*** 557,561 ****
Discussion of major patches is carried out on the Python-Dev mailing list.
For simple patches, the SourceForge comment mechanism should be sufficient.
! [xxx an email gateway would be great, ditto Ping's Roundup]</blockquote>
<h4>Accepted</h4>
--- 558,572 ----
Discussion of major patches is carried out on the Python-Dev mailing list.
For simple patches, the SourceForge comment mechanism should be sufficient.
! [xxx an email gateway would be great, ditto Ping's Roundup]<br />
! For the reviewer: If you're certain the patch should be applied,
! change the status to Accepted and assign it back to the submitter (if
! possible) for checkin. If you're certain the patch should never be
! accepted, change the status to Rejected and assign it to None. If you
! have specific complaints that would cause you to change your mind,
! explain them clearly in a comment, leave the status Open, and reassign
! back to the submitter. If you're uncertain, leave the status Open, explain
! your uncertainies in a comment, and reassign the patch to someone
! you believe can address your remaining questions; or leave the status
! Open and bring it up on Python-Dev.</blockquote>
<h4>Accepted</h4>
***************
*** 574,579 ****
The patch has been accepted and applied.<br />
The previous status was Accepted, or possibly Open if the submitter was
! Guido (or moral equivalent in some particular area of
! expertise).</blockquote>
<h4>Rejected</h4>
--- 585,589 ----
The patch has been accepted and applied.<br />
The previous status was Accepted, or possibly Open if the submitter was
! Guido (or moral equivalent in some particular area of expertise).</blockquote>
<h4>Rejected</h4>
***************
*** 581,591 ****
<blockquote>
The patch has been reviewed and rejected.<br />
! When the objections are addressed, the status may change to Open again.<br
! />
! The person changing the status to Rejected should assign the patch back to
! the submitter, or if it's clear the patch will never be accepted, assign it
! to None.<br />
! Note that SourceForge allows the submitter to overwrite the patch with a new
! version.</blockquote>
<h4>Out of date</h4>
--- 591,597 ----
<blockquote>
The patch has been reviewed and rejected.<br />
! There are generally no transitions out of this state: the patch is dead.<br />
! The person changing the status to Rejected should assign it to None.<br />
! </blockquote>
<h4>Out of date</h4>