[issue40764] Conflation of Counter with Multiset

Raymond Hettinger report at bugs.python.org
Mon May 25 13:23:39 EDT 2020


Raymond Hettinger <raymond.hettinger at gmail.com> added the comment:

For the most part, Counter() works fine with negative counts.  The update() and subtract() methods were specifically designed to work with negative values.  Nothing prevents use cases with negative counts.

In addition, there are some methods like elements() that only make sense with positive counts.  So if your use case has negative counts, then these methods methods wouldn't be applicable.

Should the Counter() have been two different classes?  Maybe yes, maybe no.  But that ship sailed a long time ago.  For now, it is what it is and wouldn't be easy to change without breaking a lot of code.

>From the outset, the central concept of Counter() is that it is a dictionary that returns zero when a value is missing.  Pretty much everything else is a set of convenience methods supporting all the different ways people aspire to use it (multisets, bags, counters, sparse arrays, etc).  People needing multiset methods use the multiset methods.  People want negative counts use the other methods.

Am marking this a closed.  There isn't much that can be changed here.  Also, theoretical objections aside, what we have now seems to be working well enough for most people most of the time.

----------
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue40764>
_______________________________________


More information about the Python-bugs-list mailing list