[issue42745] [subinterpreters] Make the type attribute lookup cache per-interpreter

[Pablo Galindo Salgado]

Pablo Galindo Salgado <pablogsal at gmail.com> added the comment:

41010184880151d6ae02a226dbacc796e5c90d11 introduced some reference leaks:

https://buildbot.python.org/all/#/builders/384/builds/136

41010184880151d6ae02a226dbacc796e5c90d11 is the first bad commit
commit 41010184880151d6ae02a226dbacc796e5c90d11
Author: Victor Stinner <vstinner at python.org>
Date:   Sat Dec 26 01:45:43 2020 +0100

    bpo-42745: Make the type cache per-interpreter (GH-23947)

    Make the type attribute lookup cache per-interpreter.

    Add private _PyType_InitCache() function, called by PyInterpreterState_New().

    Continue to share next_version_tag between interpreters, since static
    types are still shared by interpreters.

    Remove MCACHE macro: the cache is no longer disabled if the
    EXPERIMENTAL_ISOLATED_SUBINTERPRETERS macro is defined.

 Include/internal/pycore_interp.h                   |  22 +++
 Include/internal/pycore_object.h                   |   3 +
 Include/internal/pycore_pylifecycle.h              |   2 +-
 .../2020-12-25-23-30-58.bpo-42745.XsFoHS.rst       |   1 +
 Objects/typeobject.c                               | 178 ++++++++++++---------
 Python/pylifecycle.c                               |   2 +-
 Python/pystate.c                                   |   2 +
 7 files changed, 128 insertions(+), 82 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core and Builtins/2020-12-25-23-30-58.bpo-42745.XsFoHS.rst
bisect run success

I assume PR 23953 fixes those? If that is so, could we land it before more buildbots start to fail?

----------
nosy: +pablogsal

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue42745>
_______________________________________