[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

[Tim Peters]

Tim Peters <tim at python.org> added the comment:

Yes, it's better to have tp_clear than not for a variety of reasons (including setting examples of best practice).

Best I can tell, the patch for BPO-33418 was reverted _only_ to worm around the crash in _this_ report.  That's no longer needed.  Or, if it is, we've missed something fundamental in the fix for this bug.  In which case, reverting the other patch is the only clear way to find that out quickly.  I favor getting it right.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue38006>
_______________________________________