[issue37224] test__xxsubinterpreters fails randomly

Eric Snow report at bugs.python.org
Tue Dec 17 10:52:50 EST 2019


Eric Snow <ericsnowcurrently at gmail.com> added the comment:

On Fri, Dec 13, 2019 at 8:08 PM Kyle Stanley <report at bugs.python.org> wrote:
> Yeah, I named it "_PyInterpreterIsFinalizing" and it's within Include/cpython. Definitely open
> to suggestions on the name though, it's basically just a private getter for interp->finalizing.

For a struct-specific getter we usually end the prefix with an
underscore: _PyInterpreter_IsFinalizing.  Otherwise, that's the same
name I would have used. :)

> Oh, awesome! In that case, I'll do some more rigorous testing before opening the PR then;
> [snip]
> This might be a bit of a time consuming process, but I should have time in the next week
> or so to work on it.

No worries (or hurries).  Just request a review from me when you're
ready.  Thanks again for working on this!

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue37224>
_______________________________________


More information about the Python-bugs-list mailing list