[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy report at bugs.python.org
Sun Jun 17 20:50:20 EDT 2018


Terry J. Reedy <tjreedy at udel.edu> added the comment:

What do you think of changing 'ToolTip' to 'Tooltip'?  The me, the extra 'T' is over-aggressive camel-casing that impedes rather than aids reading.

test_tooltip.py was missing the unittest invocation at the end, so I could not the tests from an editor.  Without it, coverage on my Win 10 was 24%.  With it, 91% (same missing coverage).

There are cases where 100% is close enough to impossible to just move on.  I agree that the misse here are not necessarily showstoppers.  But I like to check whether the failure does not suggest a code change. 

TclError from widget.destroy suggests that we *might* be able to cleanup better.

"The TclError exceptions are reproduced by the htest in tooltip.py. ":
With the code as is?  Or if the try-except is removed?

ValueError: where?

Other comments in the review.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue33839>
_______________________________________


More information about the Python-bugs-list mailing list