[issue35444] Unify and optimize the helper for getting a builtin object

[STINNER Victor]

STINNER Victor <vstinner at redhat.com> added the comment:

I reopen the issuue. Commit bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d introduced a new compiler warning:

gcc -pthread -c -Wno-unused-result -Wsign-compare -g -Og -Wall -O0   -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration  -I./Include/internal  -I. -I./Include    -DPy_BUILD_CORE -o Objects/object.o Objects/object.c

In file included from ./Include/object.h:715,
                 from ./Include/pytime.h:6,
                 from ./Include/Python.h:75,
                 from Objects/object.c:4:
./Include/cpython/object.h:37:51: warning: 'PyId_builtins' defined but not used [-Wunused-variable]
 #define _Py_IDENTIFIER(varname) _Py_static_string(PyId_##varname, #varname)
                                                   ^~~~~
./Include/cpython/object.h:36:66: note: in definition of macro '_Py_static_string'
 #define _Py_static_string(varname, value)  static _Py_Identifier varname = _Py_static_string_init(value)
                                                                  ^~~~~~~
Objects/object.c:20:1: note: in expansion of macro '_Py_IDENTIFIER'
 _Py_IDENTIFIER(builtins);
 ^~~~~~~~~~~~~~

----------
resolution: fixed -> 
status: closed -> open

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue35444>
_______________________________________