[issue24255] Replace debuglevel-related logic with logging

R. David Murray report at bugs.python.org
Thu Aug 2 10:28:26 EDT 2018


R. David Murray <rdmurray at bitdance.com> added the comment:

Conrad: thanks for the effort, but using f-strings with logging is counterproductive.  The idea behind logging is that the logged strings are not materialized unless something actually wants to output them.  Using fstrings means you are doing all the work of formatting the string regardless of whether or not the string is actually going to get written anywhere.  The original patch also retains the debug guards that minimize overhead when debugging is not turned on, which it doesn't look like your patch does.

Regardless, what we need at this stage is a github PR, not a patch :)

----------

_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue24255>
_______________________________________


More information about the Python-bugs-list mailing list