[issue30413] Add fnmatch.filter_false function
Serhiy Storchaka
report at bugs.python.org
Sat May 20 10:31:54 EDT 2017
Serhiy Storchaka added the comment:
In general LGTM. I left few minor comments on Rietveld. Needed the versionadded directive, Misc/NEWS and What's New entries.
But shouldn't the new function have name "filterfalse" for parallel with itertools.filterfalse? And this would better match the style of the fnmatch module, fnmatchcase doesn't contain an underscore.
Tests for fnmatch.filter are too poor. I think we should add more tests (this is other issue).
----------
nosy: +serhiy.storchaka
stage: -> patch review
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue30413>
_______________________________________
More information about the Python-bugs-list
mailing list