[issue30730] [security] Injecting environment variable in subprocess on Windows

[Larry Hastings]

Larry Hastings added the comment:

Serhiy, I don't see where you got a full review of this change.  Eryksun reviewed the code and asked for changes; you made the he asked for changes but didn't get any further review.  Nor did you get a full review / "looks good to me" from anybody.

As a matter of policy I do want to see reviews for security changes on Windows.  I've asked Steve Dower to give it a quick review.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue30730>
_______________________________________