[issue29190] Avoid possible errors in comparing strings

[Stefan Krah]

Stefan Krah added the comment:

I'm generally a little concerned about the way "bugs" are presented here recently:

In #28701 you write:

'Correctness. Since no caller checks the error of PyUnicode_CompareWithASCIIString(), it is incorrectly interpreted as "less then".'

This is just not true. When testing for equality "-1" is "not equal"
and an exception would follow anyway.

I'm also not happy with broad coccinelle patches that I see months later.

I'm not sure if you realize that other people's reputation is at
stake here. You label something as a bug (good for you), everyone
who reads your reports and commits think that a bug has been found,
which is not the case.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29190>
_______________________________________