[issue27645] Supporting native backup facility of SQLite

Aviv Palivoda report at bugs.python.org
Tue Feb 28 14:57:30 EST 2017


Aviv Palivoda added the comment:

I actually looked at the patch and have a few comments:
1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep).
2. I think that the `pysqlite_connection_backup` function will look a lot better if you will have a cleanup/error label.

I am not a core developer but I think you should open the PR as it will be easier for the CR.

----------
nosy: +palaviv

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue27645>
_______________________________________


More information about the Python-bugs-list mailing list