[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor report at bugs.python.org
Sun Feb 12 17:03:48 EST 2017


STINNER Victor added the comment:

commit c22bfaae83ab5436d008ac0d13e7b47cbe776f08
Author: Victor Stinner <victor.stinner at gmail.com>
Date:   Sun Feb 12 19:27:05 2017 +0100

    bpo-29524: Add Objects/call.c file (#12)
    
    * Move all functions to call objects in a new Objects/call.c file.
    * Rename fast_function() to _PyFunction_FastCallKeywords().
    * Copy null_error() from Objects/abstract.c
    * Inline type_error() in call.c to not have to copy it, it was only
      called once.
    * Export _PyEval_EvalCodeWithName() since it is now called
      from call.c.

Thanks Serhiy and Naoki for your reviews!

It's probably not perfect, but IMHO it's better than what we had previously, and we can rework this file later.

About file history: "git blame Objects/call.c" shows me that the first and only author, *but* "git blame -C Objects/call.c" works as expected (show the full history)!

----------
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue29524>
_______________________________________


More information about the Python-bugs-list mailing list