[issue30141] If you forget to call do_handshake, then everything seems to work but hostname checking is disabled

[Christian Heimes]

Christian Heimes added the comment:

The PR doesn't fix all bugs with the current approach. In the auto-handshake case, the struct members peer_cert and handshake_done are not set correctly. I'll look into the matter. Perhaps I can set them in the handshake or verify callback.

    if (self->peer_cert)
        X509_free (self->peer_cert);
    self->peer_cert = SSL_get_peer_certificate(self->ssl);
    self->handshake_done = 1;

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue30141>
_______________________________________