[issue28272] a redundant check in maybe_small_long

Mark Dickinson report at bugs.python.org
Mon Sep 26 04:12:23 EDT 2016


Mark Dickinson added the comment:

Thanks for the patch. I'm a bit reluctant to make changes like this unless there's a measurable performance benefit. The extra check in maybe_small_long does have a value in terms of readability and safety with respect to future maintenance, and I'd expect a competent compiler to inline maybe_small_long and elide the extra check (though I haven't looked at the assembly output to check that). So I think we shouldn't change this unless there's a clear benefit to doing so.

----------
assignee:  -> mark.dickinson
nosy: +mark.dickinson

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue28272>
_______________________________________


More information about the Python-bugs-list mailing list