[issue27377] Add smarter socket.fromfd()

[Martin Panter]

Martin Panter added the comment:

Left some minor code review nitpicks.

I opened Issue 27409 with an attempt at documenting exactly which SO_* etc symbols may be available. But so far I haven’t got any positive or negative feedback. If it were up to me, I would either commit everything except the new SO_* constants, or briefly list them in the documentation.

One more thing that occurred to me is maybe we should check for EINVAL from SO_PROTOCOL. That option was apparently added in Linux 2.6.32, and Free BSD 8.4, 9.1, 10.0. Even if you think these version numbers are too old to worry about, what happens if a Python package is compiled with a new (e.g.) OS X or Windows version that supports SO_PROTOCOL, and then run on an old (existing) OS version?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue27377>
_______________________________________