[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python
STINNER Victor
report at bugs.python.org
Tue Mar 24 12:23:35 CET 2015
STINNER Victor added the comment:
> -#if defined(HAVE_STAT) && !defined(MS_WINDOWS)
> This doesn't look correct. An equivalent replacement is
Oh, I missed the "!". Only _Py_wstat() uses this test. Windows has _wstat(), so _Py_wstat() could use it.
I added deliberately "!defined(MS_WINDOWS)" because _Py_wstat() is only used in Modules/getpath.c and this file is not compiled on Windows.
Instead of modifying _Py_wstat(), I moved it back to Modules/getpath.c. There is no need to overengineer this function only called 3 times in getpath.c.
----------
resolution: -> fixed
status: open -> closed
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue23753>
_______________________________________
More information about the Python-bugs-list
mailing list