[issue23883] __all__ lists are incomplete

[Martin Panter]

Martin Panter added the comment:

The technical bit of Issue23883_support_check__all__.v3.patch looks pretty good. Mainly some grammar suggestions for the documentation.

Issue23883_test_gettext.v2.patch looks fine; just depends on check__all__() being added.

Couple of comments about the APIs for ftplib and threading. The changes for the other modules all look good though.

Regarding name_of_module, no strong opinion, but maybe keep it as it is for simplicity. You only used it once so far I think anyway.

----------
stage: needs patch -> patch review

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue23883>
_______________________________________