[issue25941] Add 'How to Review a Patch' section to devguide

SilentGhost report at bugs.python.org
Fri Dec 25 05:19:07 EST 2015


SilentGhost added the comment:

Content of the article is in very reasonable shape, I have only couple of notes:
1. I don't think "production" is a good description of the python's repository workflow, so I'd suggest changing it to "repository".
2. Lack of links: instead of saying "check the devguide" a link to the relevant section would be useful. Though it applies even when no text is going to be saved.

Technically, there are couple more issues, such as extra empty lines at the start and end of file, page title should be followed by an empty line. Please trim all the trailing spaces. The list items should all have the same indentation. Importantly, please restrict width of each line to under 80 characters: while a couple characters above this limit typically will do no harm, the lines should generally be of the same width. More links!

----------
nosy: +SilentGhost

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue25941>
_______________________________________


More information about the Python-bugs-list mailing list