[issue23830] Add AF_IUCV support to sockets

[Neale Ferguson]

Neale Ferguson added the comment:

Thanks. Question/responses in-line

On 4/1/15, 11:14 AM, "Amaury Forgeot d'Arc" <report at bugs.python.org> wrote:

>
>Amaury Forgeot d'Arc added the comment:
>
>Hi,
>First, please fill and submit a Contribution Agreement:
>https://www.python.org/psf/contrib/
Done but I never got the email confirmation - it was not in my spam fold
either.

>Then about the patch:
>- This is a patch against Python2.7, which is frozen for new
>developments. This change will only be applied to python 3.5 or later.
Understood.

>- There are some tab characters in the diff
Will fix

>- Names are limited to 8 characters, but there is no check.
I truncate, but I will add a check to be more programmer friendly

>- Names must be padded with spaces. This is done automatically in
>connect(), but these extra spaces should be removed in makesockaddr() so
>that the same names are returned.
Will do, I was going to let the caller strip() but I will do it here
instead. Is there an existing strip routine that I could call rather than
writing my own (trivial) stripper?

Do I resubmit the patch in the bug/enhancement report I had created?

Neale

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue23830>
_______________________________________