[issue22336] _tkinter should use Python PyMem_Malloc() instead of Tcl ckalloc()

STINNER Victor report at bugs.python.org
Thu Sep 11 13:18:09 CEST 2014


STINNER Victor added the comment:

I read tkinter_pymem_2.patch.

Remaining calls to ckalloc():

* they are only used to allocate events passed later to Tcl_ThreadQueueEvent(). Tcl_ThreadQueueEvent doc explicitly says that the memory must be allocated by Tcl_Alloc or ckalloc, so it's correct (PyMem cannot be used).

Remaining calls to ckfree():

* Tkapp_SplitList() calls ckfree() on memory allocated by Tcl_SplitList(), it's correct.

* Tkapp_CallDeallocArgs() ckfree() on memory allocated by PyMem_Malloc() => wrong (see my review on Rietveld).

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue22336>
_______________________________________


More information about the Python-bugs-list mailing list