[issue18678] Wrong struct members name for spwd module

[R. David Murray]

R. David Murray added the comment:

Revisiting this with fresh eyes, I no longer think this was a typo, and I think we shouldn't have changed it and should change it back (but keep the 'p' names as aliases for those who expect the man page names to be valid).

My logic is: 'sp_namp' is so named because it is a C char *pointer* to the password.  But Python doesn't have pointers in the C sense, so in the python object there is no pointer/non-pointer distinction between sp_namp, sp_pwdp, and all of the rest of the fields.  Thus the original decision to drop the 'p', which makes the names easier to type and more consistent with the other field names, there being no pointer distinction in python.

But I do like having the 'p' aliases, as I said above, because someone familiar with the C struct might use them automatically, and since this is a thin wrapper around the C API, we ought to support the C names, I think.  And besides, its too late now to remove them ;)

So, I'm reopening this because I'd like to revert the docs, remove the deprecation, and document the 'p' versions as aliases.

----------
stage: committed/rejected -> needs patch
status: closed -> open

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18678>
_______________________________________