[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti report at bugs.python.org
Sun Jun 29 11:41:04 CEST 2014


Ezio Melotti added the comment:

If someone familiar with rietveld wants to propose a patch I will review and apply it, otherwise it might take a while before I can get to it.

The patch should include these things:
1) how to make a patch that works with rietveld (this might already be mentioned somewhere in the devguide);
2) how to reach rietveld once the patch is uploaded (by clicking the review link);
3) how to use rietveld to review a patch.  This should briefly explain:
  a) the side-by-side view, the unified diff view, and the delta view;
  b) how to use the start review link and how to move between files using the keyboard shortcut or links;
  c) how to leave inline and general comments;
  d) how to go back to the issue (by clicking on the issue number on the main rietveld page)

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue13963>
_______________________________________


More information about the Python-bugs-list mailing list