[issue18528] Possible fd leak in socketmodule

[Christian Heimes]

Christian Heimes added the comment:

Coverity may not understand the interaction with errno at all. Or it may simple point out that some operating systems are not standard conform and our assumption is not universally true.

Here is a patch that raises an exception when newfd != INVALID_SOCKET.

I would not mind if we close the issue with "false positive". The code seems to work just fine on all major platforms -- or we haven't seen the issue in the wild yet.

----------
Added file: http://bugs.python.org/file31007/closesock2.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18528>
_______________________________________