[issue18339] Segfault in Unpickler_set_memo()
Serhiy Storchaka
report at bugs.python.org
Mon Jul 1 16:20:18 CEST 2013
Serhiy Storchaka added the comment:
Sorry that I was late with review. Here is some nitpicks from me.
Using assertRaises() as context manager in this case looks cleaner to me:
with self.assertRaises(ValueError):
unpickler.memo = {-1: None}
Moving the `if (idx == -1 && PyErr_Occurred())` check inside the `if (idx < 0)` block will increase the perfomance a little.
----------
nosy: +serhiy.storchaka
status: pending -> open
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18339>
_______________________________________
More information about the Python-bugs-list
mailing list