[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

[STINNER Victor]

STINNER Victor added the comment:

Your change looks perfectly valid, except this minor nit:

+        self.assertTrue(remaining_fds <= set([0, 1, 2]))

Using self.assertLessEqual() would provide better message on error.

Note: with the PEP 446, you would not have to care of closing file descriptors :-D

----------
nosy: +haypo

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18763>
_______________________________________