[issue18674] Store weak references in modules_by_index

[Antoine Pitrou]

Antoine Pitrou added the comment:

> It seems to me that the more appropriate change here would be to
> redefine PyState_FindModule as return a *new* ref rather than a
> borrowed ref and have it do the Py_INCREF before returning.
> 
> Code using it would then need to add an appropriate Py_DECREF. A
> reference leak is generally a less dangerous bug than an early free.

I hadn't thought about that. Code must add Py_DECREF only on 3.4+, then.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18674>
_______________________________________