[issue13742] Add a key parameter (like sorted) to heapq.merge
Mark Dickinson
report at bugs.python.org
Mon Apr 29 19:51:35 CEST 2013
Mark Dickinson added the comment:
Looks pretty good to me.
- There's a bonus print call in the diff.
- Should the "len(self._data)" call be protected by the lock? I can't immediately think of any reason why that would be necessary (e.g., pushpop nd poppush never change the size of self._data, so there's no risk of getting a bogus length there), but the lack of the lock makes me nervous.
- Support for iter() seems a bit out of place to me. What are the use-cases for this? Would it make sense to leave this out (for now)?
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue13742>
_______________________________________
More information about the Python-bugs-list
mailing list