[issue7100] test_xmlrpc: global name 'stop_serving' is not defined

[Jessica McKellar]

Jessica McKellar added the comment:

To summarize (as I understand it) the state of this ticket:

* stop_serving no longer exists anywhere in the code base, so the proximal  cause of the bug report from 2009 no longer exists.

* the tests in test_xmlrpc currently all pass without issue.

* If you tried to create a test in a subclass of BaseServerTestCase which never issues a request to the MyXMLRPCServer instance set up by http_server, it will hang. The reason is that BaseServerTestCase uses setUp and tearDown methods that force the test to coordinate a threading.Event with http_server; if no request is made to the XMLRPC server, the test will hang in tearDown waiting for the server to set the Event flag.

I think this ticket could be closed because the proximal issue no longer exists. Alternatively, a docstring could be added to BaseServerTestCase saying tests in subclasses must make at least 1 request else they should live in a different TestCase, or BaseServerTestCase could be refactored to not have this constraint.

----------
nosy: +jesstess

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue7100>
_______________________________________