[issue14127] add st_*time_ns fileds to os.stat(), add ns keyword to os.*utime*(), os.*utimens*() expects a number of nanoseconds

STINNER Victor report at bugs.python.org
Tue Mar 20 00:41:41 CET 2012


STINNER Victor <victor.stinner at gmail.com> added the comment:

The patch looks good to me. I was going to commit it but then I realized that Larry is a core developer. Last nits: you should add a newline after } in "} else {", and it would be better to move billion variable into fill_time(). Something like:

static void
fill_time(PyObject *v, int index, time_t sec, unsigned long nsec)
{
    ...
    static PyObject *billion = NULL;

    if (billion == NULL) {
        billion = PyLong_FromLong(1000000000);
        if (!billion)
            return;
    }
    ...
}

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue14127>
_______________________________________


More information about the Python-bugs-list mailing list