[issue16671] logging.handlers.QueueListener sentinel should not be None

[Vinay Sajip]

Vinay Sajip added the comment:

> The sentinel starts with a _, which to a casual reader (me) suggests
> that it's a private implementation detail that I should not have to
> touch. (am I right on this?)

Python is a language for consenting adults, so nothing is off-limits, except that you need to know what you are doing when you make changes to internal attributes, and may not get support from the original author if something breaks. However, notice that I set it up as a class value which could be overridden at an instance level, rather than hard-coding None into the sentinel test. So, it *was* intended to be changed if needed, but it's more appropriate for a subclass to do that than a user of the class (not that a user is *forbidden* - that couldn't be enforced, anyway).

----------
status: open -> closed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue16671>
_______________________________________