[issue16650] Popen._internal_poll() references errno.ECHILD outside of the local scope

[Gregory P. Smith]

Gregory P. Smith added the comment:

it's a potential bug.  your patch looks good.

as for _handle_exitstatus referring to SubprocessError, that is fine.  In that situation it is trying to raise the exception and the only time that would ever be a problem is when called by the gc during a __del__ where such an exception for this "impossible" situation cannot be caught anyways.  It would effectively become an uncaught NameError instead of an uncaught SubprocessError; not a big deal.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue16650>
_______________________________________