[issue14249] unicodeobject.c: aliasing warnings

STINNER Victor report at bugs.python.org
Thu Apr 5 23:00:31 CEST 2012


STINNER Victor <victor.stinner at gmail.com> added the comment:

Ok, benchmarks have spoken, amen. I applied Serhiy Storchaka's patch (version 3). I just replaced expressions in calls to Py_MAX by variables: Py_MAX is a macro and it may have to compute each expression twice. I didn't check if it's more or less efficient. Thanks Serhiy for your contribution! I added your name to Misc/ACKS.

We may change Py_MIN/Py_MAX to something more efficient using typeof():

     #define max(a,b) \
       ({ typeof (a) _a = (a); \
           typeof (b) _b = (b); \
         _a > _b ? _a : _b; })

I don't know which C compilers support it, but gcc does, at least.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue14249>
_______________________________________


More information about the Python-bugs-list mailing list