[issue12909] Inconsistent exception usage in PyLong_As* C functions

[Mark Dickinson]

Mark Dickinson <dickinsm at gmail.com> added the comment:

Looks good to me.

I'd prefer 'test_long_as_size' to be called 'test_long_as_size_t' (even though that's inaccurate for the ssize_t bits :-).

The 'Py_None' reference counting in test_long_as_size and test_long_as_double looked a little odd at first glance---particularly the lack of a Py_INCREF just before the return Py_None.  I see that it works; it just caught my eye.

Anyway, those are just nitpicks;  I leave it to you whether you want to change anything.  Otherwise, please go ahead and apply.  Thanks for the patches!

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12909>
_______________________________________