[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Senthil Kumaran]

Senthil Kumaran <senthil at uthcode.com> added the comment:

Justin,

The patch and logic is okay. We can have this is 3.3.

- I find that loop_actions as not appropriate name for the new method. It fails to give a intuitive meaning of what is supposed to do. request_action, request_action_continued or anything else which gives a meaning should be helpful.  I agree with your reasoning to provide some flexiblity for the user to override this.

- The patch lacks Documentation and tests should be added to Lib/test/test_socketserver.py.  If you can, please append the patch with these, otherwise I shall do it.

A suggestion for better method name is a must! :)

Thanks!

----------
assignee: gregory.p.smith -> orsenthil
nosy: +orsenthil

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11109>
_______________________________________