[issue1690608] email.utils.formataddr() should be rfc2047 aware

Torsten Becker report at bugs.python.org
Sun Mar 27 15:44:30 CEST 2011


Torsten Becker <torsten.becker at gmail.com> added the comment:

I implemented a basic test for the issue and an attempt for a fix.

I am not entirely sure with my implementation, specifically I would like to get comments concerning the following points:

  - Is is OK that formataddr() will now check if address is ascii safe and if not it will raise a UnicodeEncodeError?
  
  - I was not sure on the style how to append new tests to test_email.py, I just put it into the same spot where all the other formataddr() tests where, shall I put it to the end instead?


I am submitting this patch as part of my preparation for the Google Summer of Code to familiarize myself with the contribution process, any feedback on what I should do different is very welcome.

----------
keywords: +patch
nosy: +torsten.becker
Added file: http://bugs.python.org/file21429/issue-1690608.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue1690608>
_______________________________________


More information about the Python-bugs-list mailing list