[issue12009] netrc module crashes if netrc file has comment lines

[R. David Murray]

R. David Murray <rdmurray at bitdance.com> added the comment:

Here is an updated patch with the tests refactored even further.  The patch seems correct to me, and almost all the comment tests fail before the patch and pass after.

Benjamin, this patch fixes a regression relative to 2.7.1 and 3.1.3, so I'm setting it to release blocker so you can decide if it is worth putting in.  netrc is perhaps not a heavily used module, but the fact that we've had several bugs reports that have seen attention and fixes from users recently indicates it *is* used, and is probably worth fixing.  Up to you, though.  Sorry I didn't get this in before the RCs :(

The patch is for 2.7.

----------
nosy: +benjamin.peterson, georg.brandl
priority: normal -> release blocker
stage: patch review -> commit review
Added file: http://bugs.python.org/file22306/netrc-comment-fix.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12009>
_______________________________________