[issue5384] mmap and exception type

Raymond Hettinger report at bugs.python.org
Thu Jun 2 20:11:01 CEST 2011


Raymond Hettinger <raymond.hettinger at gmail.com> added the comment:

It is uncomfortable changing exception types have been a published API for over a decade, so I'll leave this one open for a bit so that others can comment.

Most of the changes in the patch are correct and match their counterparts for lists and strings.  The TypeError for slice deletion was correct as-is (it matches del 'abc'[1]).  The IndexError on slice assignment may be correct as-is (I'll do more research).  The from ValueError to SystemError is questionable.  Otherwise, the patch looks to be mostly correct (I'll give it a more thorough review later).

----------
assignee:  -> rhettinger
nosy: +rhettinger
priority: normal -> low

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5384>
_______________________________________


More information about the Python-bugs-list mailing list