[issue11351] Mac OS X os.sendfile()

Antoine Pitrou report at bugs.python.org
Mon Feb 28 15:37:16 CET 2011


Antoine Pitrou <pitrou at free.fr> added the comment:

Your patch is not cleaned up. There are strange things like:

+            ret ^= ret;

(while would you xor an off_t?)

and

+        do {    off_t x = (*buf)[i].len;
+                (*iov)[i].iov_len = x;
+                ret += x;
+        } while (0);

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11351>
_______________________________________


More information about the Python-bugs-list mailing list