[issue4681] mmap offset should be off_t instead of ssize_t, and size calculation needs corrected
Antoine Pitrou
report at bugs.python.org
Wed Feb 9 13:54:18 CET 2011
Antoine Pitrou <pitrou at free.fr> added the comment:
Thanks for doing this. Looking at the patch: Modules/_io/_iomodule.h has macros for dealing with off_t (it also defines Py_off_t for Windows), perhaps you want to use them.
Also, support.unlink() takes care of ignoring ENOENT for you.
Regardling the sizes used in the test: I think using hexadecimal literals (e.g. 0x180000000 instead of 6442450944) would make things a bit more readable :)
Part of the patch doesn't apply cleanly to latest py3k. Could you regenerate it, please?
----------
nosy: +pitrou
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue4681>
_______________________________________
More information about the Python-bugs-list
mailing list